codeant-ai-for-open-source[bot] commented on code in PR #43139:
URL: https://github.com/apache/superset/pull/43139#discussion_r3806962809
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -1134,11 +1134,11 @@ export default function TableChart<D extends DataRecord
= DataRecord>(
basicColorColumnFormatters?.length > 0
) {
backgroundColor =
- basicColorColumnFormatters[row.index][column.key]
+ basicColorColumnFormatters[row.index]?.[column.key]
?.backgroundColor || backgroundColor;
arrow =
column.label === comparisonLabels[0]
- ? basicColorColumnFormatters[row.index][column.key]?.mainArrow
+ ?
basicColorColumnFormatters[row.index]?.[column.key]?.mainArrow
: '';
Review Comment:
**Suggestion:** When both formatter arrays are present and the row has no
`basicColorColumnFormatters` entry, this assignment replaces an arrow already
computed from `basicColorFormatters` with `undefined`. The background-color
lookup preserves the previous value, but the arrow lookup does not, so a
missing column-specific entry silently removes valid comparison arrows.
Preserve the existing `arrow` when the indexed column formatter is absent.
[logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Comparison arrows disappear for mismatched formatter rows.
- ⚠️ Time-comparison cells lose valid increase/decrease indicators.
- ⚠️ Background colors and arrows show inconsistent fallback behavior.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
**Line:** 1140:1142
**Comment:**
*Logic Error: When both formatter arrays are present and the row has no
`basicColorColumnFormatters` entry, this assignment replaces an arrow already
computed from `basicColorFormatters` with `undefined`. The background-color
lookup preserves the previous value, but the arrow lookup does not, so a
missing column-specific entry silently removes valid comparison arrows.
Preserve the existing `arrow` when the indexed column formatter is absent.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43139&comment_hash=1227246a22e50eba2d1996ef9a65c5d1d0e61188dc8a97799f0a42bb9eed8e19&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43139&comment_hash=1227246a22e50eba2d1996ef9a65c5d1d0e61188dc8a97799f0a42bb9eed8e19&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
