bito-code-review[bot] commented on PR #43336: URL: https://github.com/apache/superset/pull/43336#issuecomment-5344435095
<!-- Bito Reply --> The security concern regarding CSRF protection for the export endpoint is valid. Exempting state-changing endpoints from CSRF protection can indeed expose users to cross-site request forgery attacks, especially in configurations where cookies are sent cross-site. To resolve this, you should remove the global exemption for the endpoint and implement a more secure authentication mechanism, such as a guest token or a signed request parameter, for embedded or guest scenarios. Since the file `superset/config.py` is not present in the provided PR diff, I cannot implement the fix directly. Please locate the CSRF exemption configuration in `superset/config.py` and replace the global exemption with a more granular approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
