rusackas commented on issue #43331: URL: https://github.com/apache/superset/issues/43331#issuecomment-5345841015
This has come up before, and there are some open questions about how to support it, IF we want to do it. Drill By was the "flexible" and "global" option selected for these reasons. 1) Should it be part of form data, i.e. the responsibility of the chart? That means if you want several charts representing the same data, you have to redefine that hierarchy multiple times, which is a drag. 2) If the data model changes, that form data may break. 3) Is it plausible to do this at the dataset level, so it can be used automatically by any chart, and across multiple charts? 4) If so, how do other semantic layers fit in? I would assume that's where hierarchy should REALLY be defined, if they're being used. Other than that, I'll let people weigh in with their thoughts. My only thing would be that we're trying to avoid proliferation of feature flags. If there's consensus on the SIP, I'd say skip the flag and ship the feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
