villebro commented on code in PR #43337:
URL: https://github.com/apache/superset/pull/43337#discussion_r3815563555
##########
superset/models/helpers.py:
##########
@@ -2214,6 +2214,7 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
# Update result with processed data
result.df = df
+ result.sql_rowcount = len(df.index)
Review Comment:
Makes sense. Unless it's critical for v0 -> v1 migrations we can probably
defer this to v2 chart framework, where we're planning on introducing
`result_context`, in which you can add arbitrary extra context on
transformation operations that have taken place after query results were
received from the query engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
