mikebridge opened a new pull request, #43350:
URL: https://github.com/apache/superset/pull/43350

   ### SUMMARY\n\nChart hydration can populate default control values that were 
absent or null in the persisted chart. Saving immediately afterward made those 
automatic normalization changes appear as user-authored version 
history.\n\nThis change records presence-aware hydration transitions in the 
frontend, invalidates that evidence when a user or non-UI action changes a 
control, and sends the remaining advisory metadata atomically with an 
existing-chart save. The backend validates the bounded metadata against the 
exact before/after params and omits only matching normalization noise from the 
readable change records. Persisted chart params and version snapshots remain 
unchanged.\n\nThe metadata is fail-open: malformed, stale, ambiguous, or 
mismatched entries do not suppress history.\n\n### BEFORE/AFTER SCREENSHOTS OR 
ANIMATED GIF\n\nNot applicable. This changes version-history attribution rather 
than visual presentation.\n\n### TESTING INSTRUCTIONS\n\n1. Enable .\n2. Open 
an existing 
 chart whose saved params omit a control that receives a default during Explore 
hydration.\n3. Save the chart without touching that control.\n4. Confirm the 
automatic default transition is absent from the readable version-history 
changes.\n5. Repeat after intentionally changing a control and confirm the 
intentional change remains visible.\n6. Confirm the saved chart params and 
restorable snapshot still contain the complete post-save state.\n\nAutomated 
coverage:\n\n-  — 44 passed\n- Focused Jest suites for hydration, save actions, 
reducer, and middleware — 48 passed\n- Feature-scoped MyPy, TypeScript, Ruff, 
formatter, and frontend lint checks pass\n\nThe repository-wide all-files check 
also exposes pre-existing current-master failures outside this diff: a MyPy 
error in  and unrelated ECharts test type errors.\n\n### ADDITIONAL 
INFORMATION\n\n- [ ] Has associated issue:\n- [x] Required feature flags: \n- 
[x] Changes UI\n- [ ] Includes DB Migration (follow approval process in [SIP-
 59](https://github.com/apache/superset/issues/13351))\n  - [ ] Migration is 
atomic, supports rollback & is backwards-compatible\n  - [ ] Confirm DB 
migration upgrade and downgrade tested\n  - [ ] Runtime estimates and downtime 
expectations provided\n- [x] Introduces new feature or API\n- [ ] Removes 
existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to