rusackas commented on PR #41468: URL: https://github.com/apache/superset/pull/41468#issuecomment-5351357722
@sha174n good catches. Dropped `allow-same-origin` from the sandbox, no reason to pair it with allow-scripts for third-party embeds. Also added a test that exercises the CSP merge through a real Flask response rather than a bare `Response()` object. The global/UX-only trust boundary is already called out in `SIP.md` and the docstrings, but say the word if that's not enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
