sadpandajoe opened a new pull request, #43354: URL: https://github.com/apache/superset/pull/43354
### SUMMARY Opening a dashboard permalink and editing a chart into Explore, then refreshing the Explore page, can render Explore's "missing datasource" error. `RESERVED_CHART_URL_PARAMS` was missing `permalink_key`, so a dashboard-scoped permalink key could be copied into a chart-scoped Explore URL by the URL-rewrite logic in `ExploreViewContainer`. On refresh, that key is sent to the backend and resolved against the wrong key-value namespace (dashboard vs. explore permalinks use different backend resources/salts), which fails and surfaces as a missing-datasource error. This adds `permalink_key` to `RESERVED_CHART_URL_PARAMS`, mirroring its existing presence in `RESERVED_DASHBOARD_URL_PARAMS` and the same exclusion pattern already used in the dashboard's native filter bar. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — this is a fix to URL-parameter handling, not a visual change. ### TESTING INSTRUCTIONS 1. Open a dashboard. 2. Open the vertical ellipsis menu on any chart and choose Share > Copy permalink to clipboard. 3. Open the dashboard using that permalink URL. 4. Edit the chart from the dashboard (opens Explore). 5. Refresh the Explore page. 6. Before this change: the page can show a "missing datasource" error. After this change: the chart loads normally. Also covered by the added unit test: `superset-frontend/src/constants.test.ts`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
