SEPURI-SAI-KRISHNA commented on issue #43356: URL: https://github.com/apache/superset/issues/43356#issuecomment-5352172653
One sequencing note for whoever picks this up: the fix should land **after** #43205, not before. Deriving `time_grain`'s choices from `PROPHET_TIME_GRAIN_MAP` publishes whatever the map currently holds, and the map is smaller than the advertised set until #43205 lands: | fix lands | Prophet's advertised grains | effect | | --- | --- | --- | | before #43205 | 19 -> 16 | `PT5S`, `PT30S`, `PT6H` stop being advertised, then #43205 re-adds them | | after #43205 | 19 -> 21 | no grain loses advertisement; only addon keys drop, which is the intent | On master the map has 16 keys against 19 built-ins, so the three unmapped built-ins would be removed from the published spec and then restored a release later. After #43205 the map is a strict superset of the built-ins, so the only thing the change removes is the addon keys this issue is about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
