sadpandajoe commented on code in PR #43112:
URL: https://github.com/apache/superset/pull/43112#discussion_r3819566119
##########
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/transformProps.ts:
##########
@@ -244,11 +247,19 @@ export default function transformProps(
if (!legendSort) return 0;
return legendSort === 'asc' ? a.localeCompare(b) : b.localeCompare(a);
});
+ const isHorizontalLegend = [
+ LegendOrientation.Top,
+ LegendOrientation.Bottom,
+ ].includes(legendOrientation);
+ const resolvedLegendMargin =
Review Comment:
For a wrapped horizontal List legend, this supplies `40` as `currentMargin`,
but the shared layout calculation still derives its multi-row requirement from
the regular 20px default. Two rows therefore resolve to `max(40, 20 + 24) =
44`, rather than reserving the 40px base plus another row, so the additional
row can still overlap the funnel. Could the chart-specific base be made
available to that calculation and covered with a wrapped List-legend case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
