sadpandajoe commented on code in PR #35542:
URL: https://github.com/apache/superset/pull/35542#discussion_r3825416433
##########
superset/tags/models.py:
##########
@@ -104,6 +104,8 @@ class Tag(CoreTag, AuditMixinNullable):
security_manager.user_model, secondary=user_favorite_tag_table
)
+ __table_args__ = (UniqueConstraint("name", "type",
name="uix_tag_name_type"),)
Review Comment:
This changes the persisted uniqueness contract, but there is no regression
coverage for it. Could this add a database integration test that creates two
tags with the same name and different `TagType` values, then asserts both
persist (while the same name/type still raises)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
