codeant-ai-for-open-source[bot] commented on code in PR #43316: URL: https://github.com/apache/superset/pull/43316#discussion_r3826335839
########## superset/coordination/utils.py: ########## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Helpers for the coordination service.""" + +from __future__ import annotations + +import logging +from typing import Any + +logger = logging.getLogger(__name__) + + +def close_pubsub(pubsub: Any) -> None: + """Best-effort unsubscribe + close of a pub/sub subscription.""" + try: + pubsub.unsubscribe() + pubsub.close() Review Comment: **Suggestion:** If `pubsub.unsubscribe()` raises, execution skips `pubsub.close()` because both calls are in the same `try` block. This leaves the native Redis/pub/sub connection open, and every caller uses this helper from `finally` or listener teardown, so an unsubscribe failure can leak a connection. Attempt the close independently even when unsubscribe fails, while retaining best-effort error handling. [resource leak] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ❌ Failed listener teardown can retain Redis pub/sub connections. - ⚠️ Repeated failures may exhaust the coordination connection pool. - ⚠️ GTF and GAQ coordination listeners can lose availability. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/coordination/utils.py **Line:** 30:31 **Comment:** *Resource Leak: If `pubsub.unsubscribe()` raises, execution skips `pubsub.close()` because both calls are in the same `try` block. This leaves the native Redis/pub/sub connection open, and every caller uses this helper from `finally` or listener teardown, so an unsubscribe failure can leak a connection. Attempt the close independently even when unsubscribe fails, while retaining best-effort error handling. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43316&comment_hash=43a8e3d5490ded3b2a4fe947666ac1ab8551504e2603748bea0f64933c9bf547&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43316&comment_hash=43a8e3d5490ded3b2a4fe947666ac1ab8551504e2603748bea0f64933c9bf547&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
