rusackas commented on code in PR #42598:
URL: https://github.com/apache/superset/pull/42598#discussion_r3831188450
##########
superset/extensions/metadb.py:
##########
@@ -119,6 +148,53 @@ def create_connect_args(self, url: URL) ->
tuple[tuple[()], dict[str, Any]]:
},
)
+ def do_execute(
+ self,
+ cursor: Any,
+ statement: str,
+ parameters: Any,
+ context: Any = None,
+ ) -> None:
+ with self._flag_multi_table_query(statement):
Review Comment:
Good catch, fixed. SQL Lab runs through `engine.raw_connection()` and a raw
DBAPI cursor, which never touches `do_execute*`. Moved the flag into
`on_connect` instead, wrapping the connection's own `cursor()` so it catches
that path too. Added a regression test that goes through `raw_connection()`
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
