mikebridge opened a new pull request, #43401: URL: https://github.com/apache/superset/pull/43401
### SUMMARY With soft delete enabled, the archive confirmation told users their chart, dashboard, or dataset "will be moved to Recently Archived" without saying where that is. QA (SC-117152, TC-099/TC-101) compared the modal against the design of record and found the recovery-location hint missing — the one genuine usability gap among the diffs: a user reading only the modal had no way to know recovery lives under **Settings → Manage → Recently Archived**. The confirmation body now names the location in all four variants (singular/plural, with and without a configured retention window): > This chart will be moved to Recently Archived **in the Settings menu**. You can recover it there within 30 days. Each variant remains a single, complete translation unit; only the noun and day count are interpolated. The four corresponding `messages.pot` msgids are updated in step. **Terminology decision (recorded on the ticket):** "Archive / Recently Archived" is confirmed as the copy of record — it was chosen deliberately during the soft-delete rollout to keep recoverable deletion distinct from the "Delete permanently" purge action offered on the recovery page. The design node's "Delete / Recently Deleted" wording is the stale side and is being updated separately by design; that work does not block this change. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Copy-only change; QA's before screenshots are attached to [SC-117152]. Before/after body text: | | Body | |---|---| | Before | This chart will be moved to Recently Archived. You can recover it there within 30 days. | | After | This chart will be moved to Recently Archived **in the Settings menu**. You can recover it there within 30 days. | ### TESTING INSTRUCTIONS 1. Enable `SOFT_DELETE`. 2. Trigger delete on a chart, dashboard, or dataset (single and bulk). 3. The confirmation body names the recovery location; title and button still read "Archive". 4. `npm run test -- src/utils/softDeleteCopy.test.ts` — 9 tests, expectations updated to the new copy. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> - [ ] Has associated issue: - [x] Required feature flags: `SOFT_DELETE` (copy renders only with the flag on; flag-off copy unchanged) - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Introduces new feature or API - [ ] Removes existing feature or API This PR was developed with AI assistance (Claude Code); a human (@mikebridge) reviews before undrafting. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
