codeant-ai-for-open-source[bot] commented on code in PR #43402:
URL: https://github.com/apache/superset/pull/43402#discussion_r3833446683
##########
superset/commands/chart/delete.py:
##########
@@ -32,11 +33,62 @@
from superset.daos.report import ReportScheduleDAO
from superset.exceptions import SupersetSecurityException
from superset.models.slice import Slice
+from superset.reports.models import ReportSchedule
from superset.utils.decorators import on_error, transaction
logger = logging.getLogger(__name__)
+def build_blocked_by_reports_message(
+ charts: list[Slice],
+ reports: list[ReportSchedule],
+ single_target: bool,
+) -> str:
+ """Build the user-facing message naming the alerts/reports that block
deletion.
+
+ Groups the blocking reports per chart, sorted by chart name (chart id as
+ the tie-breaker) and then report name so the message is deterministic
+ across database backends, and appends the remedy sentence. When the
+ command targets a single chart id the group prefix is dropped — in the
+ single-delete endpoint the surrounding toast already names the chart, and
+ in a one-chart bulk selection the user's own selection provides the
+ context. A multi-id command keeps the prefix on every group because the
+ bulk toast is generic, so the prefix is the only chart identification the
+ user gets.
+ """
+ sentences: list[str] = []
+ if single_target:
+ names = sorted(report.name for report in reports)
+ sentences.append(
+ str(
+ _(
+ "This chart is used by alerts or reports: %(names)s.",
+ names=", ".join(names),
+ )
+ )
+ )
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag the chart deletion guard for exposing unfiltered report names
when this is pre-existing behavior and unchanged by the current change; treat
tightening disclosure as a separate scoped issue.
**Applied to:**
- `superset/commands/chart/delete.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
