codeant-ai-for-open-source[bot] commented on code in PR #43425:
URL: https://github.com/apache/superset/pull/43425#discussion_r3836570506
##########
superset-frontend/src/explore/components/ControlHeader.tsx:
##########
@@ -89,21 +91,29 @@ const ControlHeader: FC<ControlHeaderProps> = ({
position: absolute;
top: 50%;
right: 0;
+ z-index: 1;
padding-left: ${theme.sizeUnit}px;
transform: translate(100%, -50%);
white-space: nowrap;
+ pointer-events: auto;
`}
>
{description && (
- <span>
+ <span
+ data-test={`${name}-description-icon`}
+ onMouseEnter={() => onDescriptionHoverChange?.(true)}
+ onMouseLeave={() => onDescriptionHoverChange?.(false)}
+ >
<Tooltip
id="description-tooltip"
title={description}
placement="top"
+ mouseLeaveDelay={0}
>
<Icons.InfoCircleOutlined
css={iconStyles}
onClick={tooltipOnClick}
+ aria-label={t('Show info tooltip')}
/>
Review Comment:
**Suggestion:** The icon is given an accessible name but remains a
non-focusable SVG inside a plain span; keyboard and assistive-technology users
cannot reach or activate the existing `tooltipOnClick` action. Make the icon
wrapper keyboard-focusable with appropriate button semantics and keyboard
activation, or remove the action-oriented `aria-label` if the icon is
intentionally hover-only. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Keyboard users cannot reach described Explore controls' info actions.
- ⚠️ Screen readers announce an unavailable button action.
- ⚠️ `tooltipOnClick` remains mouse-only for control headers.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/components/ControlHeader.tsx
**Line:** 113:117
**Comment:**
*Api Mismatch: The icon is given an accessible name but remains a
non-focusable SVG inside a plain span; keyboard and assistive-technology users
cannot reach or activate the existing `tooltipOnClick` action. Make the icon
wrapper keyboard-focusable with appropriate button semantics and keyboard
activation, or remove the action-oriented `aria-label` if the icon is
intentionally hover-only.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43425&comment_hash=4c00126365b9787e3dd10e77612808993a0eafda3d2f6f8ed0137a762ea32a19&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43425&comment_hash=4c00126365b9787e3dd10e77612808993a0eafda3d2f6f8ed0137a762ea32a19&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
