krishn1301 commented on PR #42854:
URL: https://github.com/apache/superset/pull/42854#issuecomment-5381836858
Closing this — the fix landed in master via #42756 (commit `148ffaff`),
which reached the same conclusion and covers it with equivalent tests.
For anyone reading this later, the merged guard is slightly broader than
mine and better for it:
```ts
if (stack && !numericValue) {
return '';
}
```
Mine only special-cased `0`. `!numericValue` also catches `null`, which
likewise renders a zero-height segment, so the merged version handles a case
I'd missed.
Thanks @sadpandajoe for the review, and no hard feelings about the race —
glad the bug is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
