codeant-ai-for-open-source[bot] commented on code in PR #43427:
URL: https://github.com/apache/superset/pull/43427#discussion_r3836716679
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/eChartOptionsSchema.ts:
##########
@@ -114,6 +114,23 @@ export const textStyleSchema = z.object({
// Style Schemas
//
=============================================================================
+/** Repeating tile pattern painted over a fill, e.g. hatching */
+export const decalSchema = z.object({
+ symbol: z.union([symbolTypeSchema, z.array(symbolTypeSchema)]).optional(),
+ symbolSize: z.number().optional(),
+ symbolKeepAspect: z.boolean().optional(),
+ color: colorSchema.optional(),
+ backgroundColor: colorSchema.optional(),
+ dashArrayX: z
+ .union([z.number(), z.array(z.union([z.number(), z.array(z.number())]))])
+ .optional(),
Review Comment:
**Suggestion:** The `dashArrayX` schema accepts heterogeneous arrays such as
`[1, [2, 3]]` because each outer element independently allows either a number
or a number array. ECharts expects this option to be one uniform
representation—`number`, `number[]`, or `number[][]`—so malformed mixed values
pass validation and are forwarded to the renderer. Model the union at the array
level to reject mixed nesting. [type error]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Custom ECharts decal validation accepts malformed mixed arrays.
- ⚠️ Timeseries custom options can forward invalid decal geometry.
- ⚠️ ECharts may ignore or mishandle the affected pattern.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/utils/eChartOptionsSchema.ts
**Line:** 124:126
**Comment:**
*Type Error: The `dashArrayX` schema accepts heterogeneous arrays such
as `[1, [2, 3]]` because each outer element independently allows either a
number or a number array. ECharts expects this option to be one uniform
representation—`number`, `number[]`, or `number[][]`—so malformed mixed values
pass validation and are forwarded to the renderer. Model the union at the array
level to reject mixed nesting.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43427&comment_hash=651f8bc62761b980f0d4b3cb372c1317dd574ce5bc7384d10e853e0734b71165&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43427&comment_hash=651f8bc62761b980f0d4b3cb372c1317dd574ce5bc7384d10e853e0734b71165&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
