sonfire186 commented on PR #40970: URL: https://github.com/apache/superset/pull/40970#issuecomment-5385703447
> @sonfire186 codeant's thread on this is still nagging at me and "it doesn't work that way" is a little nebulous, and looking at it a bit more, I'm still wondering if it's right. > > `inverseSelection` gets passed to `StyledSpace` regardless of `appSection`, but the exclude select only renders when `appSection !== AppSection.FilterConfigModal`. So in the config modal preview, with inverse selection on, there's just one `.ant-space-item`, and it matches both `:first-of-type` and `:last-child`. The later rule wins the cascade, giving it `flex: 3 1 75%` instead of full width. Can you actually check that case in the modal, or explain why it doesn't apply? I don't understand how it works, but inversion doesn't work for me. This fix corrects that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
