codeant-ai-for-open-source[bot] commented on code in PR #43432:
URL: https://github.com/apache/superset/pull/43432#discussion_r3838976961
##########
superset/examples/birth_names.py:
##########
@@ -176,7 +176,7 @@ def create_slices(tbl: SqlaTable) -> tuple[list[Slice],
list[Slice]]:
"compare_lag": "10",
"compare_suffix": "o10Y",
"limit": "25",
- "granularity_sqla": "ds",
+ "granularity": "ds",
Review Comment:
**Suggestion:** The modern `granularity` key is not handled when rebuilding
a `big_number` query from saved form data:
`form_data_query_context._columns_and_metrics` only promotes `granularity_sqla`
to the time column. Consequently, exports or fallback query paths for the
Participants trendline produce an aggregate without the `ds` column and lose
the trendline time series. Update the rebuild logic to recognize `granularity`
as well, or retain the legacy key until that consumer is updated. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Birth names Big Number exports lose trendline time columns.
- ⚠️ Excel fallback queries return one aggregate instead of a series.
- ⚠️ Other modern-key Big Number fallback charts share this mismatch.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/examples/birth_names.py
**Line:** 179:179
**Comment:**
*Api Mismatch: The modern `granularity` key is not handled when
rebuilding a `big_number` query from saved form data:
`form_data_query_context._columns_and_metrics` only promotes `granularity_sqla`
to the time column. Consequently, exports or fallback query paths for the
Participants trendline produce an aggregate without the `ds` column and lose
the trendline time series. Update the rebuild logic to recognize `granularity`
as well, or retain the legacy key until that consumer is updated.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43432&comment_hash=a96679bec074490cfc471b04b0356c2309380b10e9af80dbe5356773c880e676&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43432&comment_hash=a96679bec074490cfc471b04b0356c2309380b10e9af80dbe5356773c880e676&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
