codeant-ai-for-open-source[bot] commented on code in PR #43434:
URL: https://github.com/apache/superset/pull/43434#discussion_r3839140202
##########
superset-websocket/src/config.ts:
##########
@@ -144,11 +144,10 @@ function applyEnvOverrides(config: ConfigType):
ConfigType {
LOG_LEVEL: val => (config.logLevel = val),
LOG_TO_FILE: val => (config.logToFile = toBoolean(val)),
LOG_FILENAME: val => (config.logFilename = val),
- REDIS_STREAM_PREFIX: val => (config.redisStreamPrefix = val),
- REDIS_STREAM_READ_COUNT: val =>
- (config.redisStreamReadCount = toNumber(val)),
- REDIS_STREAM_READ_BLOCK_MS: val =>
- (config.redisStreamReadBlockMs = toNumber(val)),
+ ENTITY_CHANGES_CHANNEL_PREFIX: val =>
+ (config.entityChangesChannelPrefix = val),
+ PER_PRINCIPAL_CHANNEL_PREFIX: val =>
+ (config.perPrincipalChannelPrefix = val),
Review Comment:
**Suggestion:** The new environment overrides let the WebSocket service
subscribe to custom Redis prefixes, but the Superset producer still publishes
to hard-coded `entity-changes:` and `realtime:` prefixes and exposes no
corresponding application configuration. Setting either override therefore
makes the WebSocket service subscribe to channels that producers never publish
to, silently disabling realtime delivery. Remove these independent overrides or
wire the same values through the Flask configuration and producer. [api
mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Custom entity-change prefixes receive no producer messages.
- ❌ Custom per-principal prefixes break task-status delivery.
- ⚠️ Chart updates fall back to interval polling.
- ⚠️ Docker defaults mask the mismatch unless overridden.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-websocket/src/config.ts
**Line:** 147:150
**Comment:**
*Api Mismatch: The new environment overrides let the WebSocket service
subscribe to custom Redis prefixes, but the Superset producer still publishes
to hard-coded `entity-changes:` and `realtime:` prefixes and exposes no
corresponding application configuration. Setting either override therefore
makes the WebSocket service subscribe to channels that producers never publish
to, silently disabling realtime delivery. Remove these independent overrides or
wire the same values through the Flask configuration and producer.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43434&comment_hash=2cec173196f33a8513883012712b9c4d3afe1dd920495823419bd55d9aad4151&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43434&comment_hash=2cec173196f33a8513883012712b9c4d3afe1dd920495823419bd55d9aad4151&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
