rusackas commented on PR #43144: URL: https://github.com/apache/superset/pull/43144#issuecomment-5398549122
One thing before I approve, though. The description says existing Bar charts keep their current placement unless someone opts into Auto, but `DEFAULT_FORM_DATA.valueLabelPosition` is `Auto`, and `transformProps` falls back to it whenever the field's missing, which is every existing chart with Show Value on today. The legacy test you added for that exact case confirms it. Auto can drop labels entirely on stacked segments under 16px, so that's every upgraded dashboard, not just new opt-ins. Intentional? If so the description should say that plainly. If not, legacy/undefined should probably resolve to Outside End instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
