rusackas commented on PR #43312: URL: https://github.com/apache/superset/pull/43312#issuecomment-5398526289
One thing before I approve, though. `adhoc_metric_to_sqla`'s SIMPLE branch falls back to `column(column_name)` directly when the metric's column isn't in `columns_by_name`, so it skips `get_sqla_col()` and the new `prepare_identifier` quoting. Should that fallback route through it too, for the same case-sensitive Snowflake columns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
