rusackas commented on PR #43230:
URL: https://github.com/apache/superset/pull/43230#issuecomment-5399658224
Codeant's thread on this is still open and worth acting on: `result.then(()
=> {}, () => {})` swallows both success and failure, so a failing
`test-storybook` run would still exit 0 and CI would report green. Can you set
`process.exitCode` in the handlers instead (0 on success, 1 on failure) rather
than the no-ops?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
