EnxDev commented on PR #43296:
URL: https://github.com/apache/superset/pull/43296#issuecomment-5400018564
Thanks for both notes — answers below.
> `SamplesPane` passes its page size as `rowLimit`... is that copy intended
there? / is that the intended state there?
No, not intended — good catch. The Samples pane's row limit is just this
pane's own page-size selector, not a chart's `row_limit`, so showing "The row
limit set for the chart was reached. The chart may show partial data." there
was wrong copy. Fixed by adding an optional `limitReachedMessage` override on
`RowCountLabel`/`TableControls`; `SamplesPane` now supplies its own wording
("The sample row limit was reached. This dataset may contain more rows.")
instead of the chart-specific message.
> This assertion can't fail... needs `findByRole`/`await waitFor` to fail on
a regression.
Confirmed. The test asserted tooltip absence synchronously right after
`hover`, before antd's 0.1s `mouseEnterDelay` could ever show it, so it passed
unconditionally regardless of the actual logic. Fixed by waiting past the delay
before asserting absence. Verified the fix is actually load-bearing by
temporarily forcing `limitReached = true` in `RowCountLabel` — the test failed
as expected — then reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
