Vitor-Avila opened a new pull request, #43489:
URL: https://github.com/apache/superset/pull/43489
### SUMMARY
When setting up a new DB connection via the SQLAlchemy URI string ("Other"
option in the dropdown) the "Test connection" button needs to return a `2xx`
response to unblock saving the connection.
This flow wasn't working properly for DB connections powered by OAuth2.
These connections won't work right away, as there isn't an OAuth2 token for the
user yet. The UI should let the user store the credentials, and then the user
can get an OAuth2 token via Explore, SQL Lab, etc.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
### TESTING INSTRUCTIONS
Try creating an OAuth2 connection using the SQLAlchemy URI string and
confirm it works.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
