mikebridge commented on PR #43490: URL: https://github.com/apache/superset/pull/43490#issuecomment-5401523173
**Coordination note for whoever merges this:** #43485 (SC-115342, block-reason column) touches the same subsystem and four of the same files — `superset/commands/deletion_retention/audit.py`, `superset/models/purge_audit_log.py`, `superset/tasks/deletion_retention.py`, and `UPDATING.md`. The two changes are semantically independent: that one adds a nullable `reason` column with a migration; this one is deletion-only and adds no schema, so there is **no alembic chaining to manage** in either direction. The overlaps are textual only — here they are a public `utc_now` in `audit.py` (was `_utc_now`, now shared with the pruner so cutoffs and `created_on` cannot drift apart), an `ALL_STATUSES` constant on the model, a new task in `tasks/deletion_retention.py`, and a new `UPDATING.md` entry. Whichever lands second rebases; no ordering preference from this side. One thing worth knowing if the reason column ever grows the status vocabulary: this PR adds an exhaustiveness test asserting every status in `ALL_STATUSES` falls into exactly one retention category, so a new status without a category fails a test rather than silently never being pruned. *Comment by Claude (AI) on behalf of @mikebridge.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
