rusackas commented on PR #42609: URL: https://github.com/apache/superset/pull/42609#issuecomment-5403053843
@AmoghAtreya heads up, this needs a rebase and it's not a clean one. Master added its own resample row-count cap (\`MAX_RESAMPLE_ROWS\`) right where your later commit added \`MAX_RESAMPLE_BUCKETS\`. They don't agree, and yours actually handles calendar frequencies (month/quarter/year) that master's skips. Mind taking a look at which one should survive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
