rusackas commented on issue #29697: URL: https://github.com/apache/superset/issues/29697#issuecomment-5405328567
Thanks @endimonan, the minimal repro was exactly what was needed to pin this down. Root cause: `Slice.datasource` only ever resolves the `table` relationship, so `datasource_type: "saved_query"` was always going to be a dead end — `SavedQuery` has no `.name` attribute, which is what crashes with the 500. `datasource_type: "query"` has the same underlying problem but doesn't crash (Query has an unrelated `.name` property used for CTAS naming), it just silently creates a chart that can never render. Given how deep the "not actually wired up" gap goes (this isn't just the `.name` line — there's no code path that can query a saved_query/query-backed chart at all), went with your second option: reject both at chart create/update time with a clean 422 instead of the opaque 500, rather than trying to build out full e2e support for something charts were never actually plumbed to do. PR: #43500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
