EnxDev commented on code in PR #43334:
URL: https://github.com/apache/superset/pull/43334#discussion_r3852259007
##########
superset/commands/dataset/create.py:
##########
@@ -50,7 +54,25 @@ def run(self) -> Model:
self.validate()
dataset = DatasetDAO.create(attributes=self._properties)
- dataset.fetch_metadata()
+ try:
+ dataset.fetch_metadata()
+ except SupersetException as ex:
Review Comment:
Not intentional, fixed. Added except `OAuth2RedirectError: raise before the
broad except SupersetException`, so it propagates unchanged instead of being
flattened into a generic DatasetInvalidError.
This matches the existing convention elsewhere in the codebase (e.g.
commands/database/create.py).
Added a regression test
(test_create_dataset_oauth2_redirect_propagates_unchanged).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
