bito-code-review[bot] commented on code in PR #43518:
URL: https://github.com/apache/superset/pull/43518#discussion_r3854754184
##########
tests/integration_tests/datasource/api_tests.py:
##########
@@ -170,6 +170,79 @@ def test_get_column_values_array_elements_param(self,
values_for_column_mock):
)
assert values_for_column_mock.call_args.kwargs["array_elements"] is
True
+ @pytest.mark.usefixtures("app_context", "virtual_dataset")
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing search kwarg assertion</b></div>
<div id="fix">
The endpoint always passes `search=search` to `values_for_column`. This test
only asserts on `array_elements`; the `search=None` kwarg is silently present
and untested. Add `assert values_for_column_mock.call_args.kwargs["search"] is
None` to prevent the `assert_called_with` failing if the call signature is
later asserted explicitly.
</div>
</div>
<small><i>Code Review Run #3b684a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
