eschutho opened a new pull request, #43520: URL: https://github.com/apache/superset/pull/43520
**Decisions made that were not in the instructions** None. ## What `QueryObject._rename_deprecated_fields` and `_move_deprecated_extra_fields` log at `WARNING` when a query context still uses a renamed/legacy field (`groupby`, `granularity_sqla`, `timeseries_limit`, `timeseries_limit_metric`, or the `extras` `where`/`having` fields). These methods run in `QueryObject.__init__`, i.e. on every render of a chart. A chart saved before the field was renamed will hit this warning on every single render until it's resaved — an indefinite repeat with nothing new to report each time. ## Change Downgrade these four `logger.warning` calls to `logger.info`. No behavior change beyond log level — the deprecated fields are still renamed/moved exactly as before. This mirrors the rationale already established in the same file for `_get_post_processing`'s "unsupported option" log line, which was deliberately kept at `info` for the identical reason (see the comment directly above it). Added a matching comment above each changed block. ## Test plan - `uvx [email protected] check` and `format --check` clean on the changed file. - No existing tests assert on the log level of these methods (grepped `tests/` for `_rename_deprecated_fields`, `_move_deprecated_extra_fields`, `DEPRECATED_FIELDS`, `DEPRECATED_EXTRAS_FIELDS` — no hits), so no test changes needed; behavior (renaming/moving the fields) is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
