aminghadersohi commented on PR #43478: URL: https://github.com/apache/superset/pull/43478#issuecomment-5414260083
CI/review sweep complete: - Replied directly to both CodeAnt review threads and resolved them. The malformed-filter assertion and stale saved-context fallback are covered by the latest branch. - The earlier Bito invalid-filter coverage suggestion is covered by `test_malformed_extra_form_data_filter_returns_clean_error`; the customer-reported `get_chart_data` unknown-column case is covered end-to-end by `test_unknown_adhoc_filter_column_returns_validation_error`. - Pulled the failed unit-test logs rather than retriggering. The sole root failure was the test double missing `query_context.form_data`; fixed by making the mocked loaded query context match the production interface. - Rebased onto current `origin/master` and ran pre-commit across every file changed by the PR successfully. - The prior Codecov patch check was green; Netlify comments are deployment status notifications and require no code change. Latest verified PR head: `e1995f71058bb33d4d34b1c5801bfec63a2df94b`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
