eschutho commented on PR #43517: URL: https://github.com/apache/superset/pull/43517#issuecomment-5412641980
@richardfogaca — assigning you as reviewer on this one (coordinating for @eschutho). Quick why: you reviewed #43081 two weeks ago, same file (`superset/charts/data/api.py`) and same class of change — converting a lower-level exception into a proper HTTP status at the chart-data API boundary — so you have the freshest context here. This is a 2-line fix for Sentry SUPERSET-PYTHON-NA4 (71.5k events, still firing ~30–40/day): a reversed date range (`since > until`) currently 500s instead of 400ing. It adds an `except ValueError` arm next to the existing `except KeyError` in `_create_query_context_from_form`, re-raising as `marshmallow.ValidationError`. `get_since_until()` itself is deliberately left unchanged (other callers catch its `ValueError`). The PR body's Tradeoffs section discloses the one behavioral nuance worth your eye — it broadens *any* `ValueError` during `ChartDataQueryContextSchema().load()` to a 400. No rush; heavy CI matrix is still running (nothing failing). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
