bito-code-review[bot] commented on PR #43413:
URL: https://github.com/apache/superset/pull/43413#issuecomment-5417177620
<!-- Bito Reply -->
The current constraint `setuptools<85` is indeed risky if `clients` still
relies on `pkg_resources`, as `setuptools` 84.0.0 and later versions may have
removed or altered the availability of `pkg_resources`. If the migration of
`clients` is not yet complete, maintaining a stricter constraint (e.g., `<81`)
is safer to prevent breaking installations during resolution. It is recommended
to keep the constraint below the removal version until the `pkg_resources`
migration is fully verified for all dependencies.
**requirements/base.in**
```
-# Pin setuptools <81 until all dependencies migrate from pkg_resources to
importlib.metadata
+# Pin setuptools <85 until all dependencies migrate from pkg_resources to
importlib.metadata
# pkg_resources is deprecated and will be removed in setuptools 81+ (around
2025-11-30)
# Known affected packages: Preset's 'clients' package
# See docs/docs/contributing/pkg-resources-migration.md for details
-setuptools<81
+setuptools<85
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
