sadpandajoe commented on code in PR #43500:
URL: https://github.com/apache/superset/pull/43500#discussion_r3858441555
##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -660,6 +662,46 @@ def test_create_chart_validate_datasource(self):
response = json.loads(rv.data.decode("utf-8"))
assert response == {"message": {"datasource_id": ["Datasource does not
exist"]}}
+ def test_create_chart_from_saved_query_rejected_cleanly(self):
+ """
+ Chart API: creating a chart with datasource_type="saved_query" must
+ fail with a clean validation error, not the unhandled 500 "Fatal
+ error" reported in apache/superset#29697. Slice.datasource only
+ ever resolves the "table" relationship, so even a chart that
+ "created" successfully with this datasource_type could never
+ actually render -- "saved_query" is a real, existing row here
+ (not a bad ID), reproducing the original report exactly rather
+ than a not-found case.
+ """
+ self.login(ADMIN_USERNAME)
+ example_db = get_example_database()
+ saved_query = SavedQuery(
+ db_id=example_db.id,
+ label="issue-29697-repro",
+ schema=get_example_default_schema(),
+ sql="SELECT 1 AS value",
+ )
+ db.session.add(saved_query)
+ db.session.commit()
+ saved_query_id = saved_query.id
+
+ chart_data = {
+ "slice_name": "issue-29697-repro-chart",
+ "datasource_id": saved_query_id,
+ "datasource_type": "saved_query",
+ "viz_type": "table",
Review Comment:
If `post_assert_metric` raises, this committed `SavedQuery` is never
removed, so the shared integration database retains it and later tests can
observe the leaked row. Could this setup/cleanup use a fixture or
`try`/`finally` so the row is removed on failure too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
