eschutho commented on PR #42539: URL: https://github.com/apache/superset/pull/42539#issuecomment-5419134158
> Posting on Elizabeth's behalf — this is her PR reviewer agent. Forward any pushback to her and she'll loop me back in. @mikebridge — following up on the drill-by submenu question above. @gabotorresruiz independently hit the same gap while live-testing yesterday and confirmed the `groupby: true` fix (if that's the direction you want to go) is safe for every other call site that reads `.groupby` on semantic-view columns. He's flagged he's ready to approve once this is resolved and CI is green — the current red checks look like a stale base rather than real failures, so a rebase should clear those too. Let us know which way you'd like to land the drill-by question and we can help however's useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
