bito-code-review[bot] commented on PR #43557:
URL: https://github.com/apache/superset/pull/43557#issuecomment-5427574286
<!-- Bito Reply -->
The flagged issue is correct. Restricting the `live` prop to
`TaskStatus.InProgress` causes the duration display to freeze when a task
enters the `aborting` state, even though the task is still technically active
and its duration is still increasing on the server. To resolve this, the `live`
condition should include `TaskStatus.Aborting` (or any other status where the
task is still considered running).
Here is the corrected implementation for
`superset-frontend/src/pages/TaskList/index.tsx`:
```tsx
<LiveDuration
durationSeconds={duration_seconds}
locale={locale}
live={realtimeEnabled && (status === TaskStatus.InProgress || status ===
TaskStatus.Aborting)}
/>
```
I have checked the PR comments and there are no other comments to address.
Would you like me to implement this fix?
**superset-frontend/src/pages/TaskList/index.tsx**
```
<LiveDuration
durationSeconds={duration_seconds}
locale={locale}
live={realtimeEnabled && (status === TaskStatus.InProgress || status ===
TaskStatus.Aborting)}
/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
