codeant-ai-for-open-source[bot] commented on code in PR #43566:
URL: https://github.com/apache/superset/pull/43566#discussion_r3867211790
##########
superset/db_engine_specs/aurora.py:
##########
@@ -36,6 +37,26 @@ class AuroraMySQLDataAPI(MySQLEngineSpec):
"region_name={region_name}"
)
+ metadata = {
+ "description": (
+ "Amazon Aurora MySQL accessed via the AWS Data API, allowing "
+ "database queries over HTTP without managing persistent
connections."
+ ),
+ "logo": "aws-aurora.jpg",
+ "homepage_url": "https://aws.amazon.com/rds/aurora/";,
+ "categories": [
+ DatabaseCategory.CLOUD,
+ DatabaseCategory.POPULAR,
+ ],
+ "pypi_packages": ["auroradataapi"],
Review Comment:
**Suggestion:** The Data API metadata advertises `auroradataapi` as the
installable PyPI package, but the existing compatible-database metadata
identifies the required SQLAlchemy dialect package as
`sqlalchemy-aurora-data-api`. Consumers following this new metadata may install
a nonexistent or insufficient package and still be unable to load the
`auroradataapi` dialect; use the actual package name. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Aurora Data API setup can fail after following metadata.
- ⚠️ Database selector dependency guidance is incorrect.
- ⚠️ SQLAlchemy dialect loading may fail for Aurora connections.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=686aa8a444c2452195485fe057081a8c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=686aa8a444c2452195485fe057081a8c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/aurora.py
**Line:** 51:51
**Comment:**
*Api Mismatch: The Data API metadata advertises `auroradataapi` as the
installable PyPI package, but the existing compatible-database metadata
identifies the required SQLAlchemy dialect package as
`sqlalchemy-aurora-data-api`. Consumers following this new metadata may install
a nonexistent or insufficient package and still be unable to load the
`auroradataapi` dialect; use the actual package name.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43566&comment_hash=d7adeec9f9f14fb56dfd0fa388dd7321b21e943b5ed61166abf8f86526d27a70&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43566&comment_hash=d7adeec9f9f14fb56dfd0fa388dd7321b21e943b5ed61166abf8f86526d27a70&reaction=dislike'>👎</a>
##########
superset/db_engine_specs/aurora.py:
##########
@@ -36,6 +37,26 @@ class AuroraMySQLDataAPI(MySQLEngineSpec):
"region_name={region_name}"
)
+ metadata = {
+ "description": (
+ "Amazon Aurora MySQL accessed via the AWS Data API, allowing "
+ "database queries over HTTP without managing persistent
connections."
+ ),
+ "logo": "aws-aurora.jpg",
+ "homepage_url": "https://aws.amazon.com/rds/aurora/";,
+ "categories": [
+ DatabaseCategory.CLOUD,
+ DatabaseCategory.POPULAR,
+ ],
Review Comment:
**Suggestion:** These metadata declarations reference
`DatabaseCategory.CLOUD` and `DatabaseCategory.POPULAR`, but neither attribute
exists on `DatabaseCategory`; importing this module will raise `AttributeError`
while creating `AuroraMySQLDataAPI`, preventing Aurora engine specs from
loading. Use defined categories such as `CLOUD_AWS` and an appropriate
database/licensing category. [import error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Aurora engine-spec imports fail immediately.
- ❌ Aurora database connections cannot resolve their engine specs.
- ⚠️ Aurora unit tests and engine registration are blocked.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=84782f5448e34da589f65165725bedc7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=84782f5448e34da589f65165725bedc7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/aurora.py
**Line:** 47:50
**Comment:**
*Import Error: These metadata declarations reference
`DatabaseCategory.CLOUD` and `DatabaseCategory.POPULAR`, but neither attribute
exists on `DatabaseCategory`; importing this module will raise `AttributeError`
while creating `AuroraMySQLDataAPI`, preventing Aurora engine specs from
loading. Use defined categories such as `CLOUD_AWS` and an appropriate
database/licensing category.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43566&comment_hash=ee038051ec8f45b40ffcbd04495c055e99b0a32ba5d0500a9ccabe03ef16328d&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43566&comment_hash=ee038051ec8f45b40ffcbd04495c055e99b0a32ba5d0500a9ccabe03ef16328d&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
