rusackas commented on PR #43000: URL: https://github.com/apache/superset/pull/43000#issuecomment-5434840201
Thanks for the thorough revision, @joe-clickhouse's live-server findings all seem to be addressed, and the tests assert DDL and dtype mapping instead of mocking SQLAlchemy away. Agreed with your call on CodeAnt's replace-isn't-atomic thread, that matches how every other spec's `if_exists='replace'` already behaves, feel free to resolve it. Needs a rebase, and `ruff-format` is failing in CI, and there are some new Bito reviews that warrant a look, but otherwise LGTM thus far. Happy to stamp this when all that's tidied up. Holler if you want a hand, I can jump in here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
