rusackas commented on PR #43184: URL: https://github.com/apache/superset/pull/43184#issuecomment-5435019882
LGTM, thanks for tracking this down @bikash-barnwal. One nit: the emit effect (DataTable.tsx:341) now also fires when all columns are hidden, since `rows` still reflects `data`. Doesn't corrupt anything today, but a `columns.length === 0` guard would keep the move truly behavior-neutral. Happy to approve if that can be touched up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
