EnxDev opened a new pull request, #43588: URL: https://github.com/apache/superset/pull/43588
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR builds on the existing Dashboard V2 prototype and expands its widget editing flow. It adds: - Searchable dataset selection for data-backed widgets - Dataset-aware column and metric pickers with keyboard-accessible reordering - Support for creating and editing simple and custom SQL ad hoc metrics - Raw JSON fallbacks when values cannot be represented by the structured controls - Structured ECharts controls for: - Bar, line, and scatter chart types - Per-series visibility, colors, and display names - Chart title, legend, tooltip, and axis configuration - Backend validation before widget properties are committed - Reusable composite controls, including the shared metric control - Dependency-ordered schema enrichment with cycle detection - An MCP tool for applying validated widget control values - Editing UI refinements, including a wider Properties panel, consistent form spacing, widget hover states, and a chart-style overflow menu The Inspector no longer duplicates placement fields or the Delete widget action. Placement remains canvas-driven, while widgets can still be removed from their headers. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> <img width="2395" height="1189" alt="Screenshot 2026-08-27 162636" src="https://github.com/user-attachments/assets/b4a1e4ec-8d4c-4485-ab0d-49e5b4be6e89"; /> <img width="2401" height="1203" alt="Screenshot 2026-08-27 162736" src="https://github.com/user-attachments/assets/8873561b-d300-4d90-8f97-c69948ec368a"; /> <img width="1600" height="1000" alt="distill-expanded" src="https://github.com/user-attachments/assets/4ee1116e-9ee9-456e-8ddb-8051f3ee57d2"; /> <img width="1600" height="1000" alt="distill-scrolled" src="https://github.com/user-attachments/assets/bdcf92e6-5933-4e90-b8dd-2f65a8d1cd78"; /> <img width="1600" height="1000" alt="distill-two-rows" src="https://github.com/user-attachments/assets/c804ba50-1e97-454b-9a19-6ff9ab85c146"; /> <img width="1600" height="1000" alt="assessmentA-08-96-series" src="https://github.com/user-attachments/assets/95af5a24-dd46-40b5-adcd-43c6ecc0b63a"; /> <img width="1600" height="1000" alt="assessmentA-09-per-series-entries" src="https://github.com/user-attachments/assets/526b8359-8fd3-48fa-887b-5c0a6d3436dc"; /> <img width="1600" height="1000" alt="assessmentA-10-json-tab" src="https://github.com/user-attachments/assets/f607ec65-5636-4b5f-ae45-63fa0e99b448"; /> <img width="1600" height="1000" alt="assessmentA-12-nothing-selected" src="https://github.com/user-attachments/assets/a2ef88e4-1e1e-410e-b0b9-1179433df162"; /> <img width="1600" height="1000" alt="assessment-b-bound" src="https://github.com/user-attachments/assets/c52279bc-e2d8-4ac6-8433-87e4c512d128"; /> <img width="1600" height="1000" alt="audit-reorder" src="https://github.com/user-attachments/assets/dd4c5e60-4234-46bb-83ac-3ef277c8ee5b"; /> <img width="1600" height="1000" alt="clarify-tooltip" src="https://github.com/user-attachments/assets/04ce7eba-51d3-45b1-8b48-999e0138dd04"; /> <img width="1600" height="1000" alt="distill-after" src="https://github.com/user-attachments/assets/2ff4d7e4-72f0-4e19-a7a5-42d299e5bf4e"; /> <img width="1600" height="1000" alt="distill-colorpicker" src="https://github.com/user-attachments/assets/23270a9a-d2a6-4ee7-804f-dd596623e704"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Open `/dashboard/v2/new/`. 2. Add an ECharts, Balloons, Table, or Metric Tile widget. 3. Select the widget and open the **Properties** tab. 4. Select a dataset and verify that its columns and saved metrics are available. 5. Add, remove, and reorder dimensions and metrics. 6. Create and edit both a simple and a custom SQL ad hoc metric. 7. Verify that keyboard controls can reorder column and metric entries. 8. Configure an ECharts widget with: - Bar, line, and scatter chart types - Per-series colors, visibility, and display names - Title, legend, tooltip, and axis settings 9. Confirm that structured settings update the rendered chart without overwriting unrelated raw ECharts options. 10. Enter an invalid control combination and verify that it is rejected without changing the widget. 11. Verify that the Inspector no longer shows Placement or Delete sections. 12. Verify that widgets can still be removed using the header bin and that the overflow menu opens. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
