sadpandajoe commented on code in PR #43054:
URL: https://github.com/apache/superset/pull/43054#discussion_r3873335711
##########
superset-frontend/package.json:
##########
@@ -265,6 +265,9 @@
"@swc/core": "^1.15.47",
"@swc/plugin-emotion": "^14.19.0",
"@swc/plugin-transform-imports": "^12.5.0",
+ "@superset-ui/eslint-plugin-i18n-strings":
"file:eslint-rules/eslint-plugin-i18n-strings",
Review Comment:
The frontend formatter rewrites this manifest on the current head, so the
required `pre-commit` job fails and the PR cannot pass CI. Could these scoped
dependencies be placed in the formatter's canonical order and the generated
file committed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
