rusackas commented on code in PR #43596:
URL: https://github.com/apache/superset/pull/43596#discussion_r3873817975


##########
docs/docs/using-superset/using-ai-with-superset.mdx:
##########
@@ -248,11 +248,12 @@ Ask your admin for the MCP server URL and any 
authentication tokens you need.
 
 ### Datasets
 
-| Tool                     | Description                                      |
-| ------------------------ | ------------------------------------------------ |
-| `list_datasets`          | List datasets with filtering and search          |
-| `get_dataset_info`       | Get dataset metadata (columns, metrics, filters) |
-| `create_virtual_dataset` | Create a virtual dataset from a SQL query        |
+| Tool                     | Description                                       
                                             |
+| ------------------------ | 
----------------------------------------------------------------------------------------------
 |
+| `list_datasets`          | List datasets with filtering and search           
                                             |
+| `get_dataset_info`       | Get dataset metadata (columns, metrics, filters)  
                                             |

Review Comment:
   Fair catch — `get_dataset_info` never returns a `filters` field, just 
columns and metrics. Fixed the row.



##########
docs/docs/using-superset/using-ai-with-superset.mdx:
##########
@@ -248,11 +248,12 @@ Ask your admin for the MCP server URL and any 
authentication tokens you need.
 
 ### Datasets
 
-| Tool                     | Description                                      |
-| ------------------------ | ------------------------------------------------ |
-| `list_datasets`          | List datasets with filtering and search          |
-| `get_dataset_info`       | Get dataset metadata (columns, metrics, filters) |
-| `create_virtual_dataset` | Create a virtual dataset from a SQL query        |
+| Tool                     | Description                                       
                                             |
+| ------------------------ | 
----------------------------------------------------------------------------------------------
 |
+| `list_datasets`          | List datasets with filtering and search           
                                             |
+| `get_dataset_info`       | Get dataset metadata (columns, metrics, filters)  
                                             |
+| `create_virtual_dataset` | Create a virtual dataset from a SQL query         
                                             |
+| `update_dataset_metric`  | Update a saved metric's expression, name, 
verbose_name, or format (requires dataset ownership) |

Review Comment:
   Added a note that editing a saved metric changes it for every chart 
referencing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to