aminghadersohi commented on PR #43598: URL: https://github.com/apache/superset/pull/43598#issuecomment-5444443907
Thanks @gabotorresruiz — you're right, and thanks for verifying it against a real dataset rather than just the mocks. Corrected the description: the string check only guards against malformed entries. `get_time_filter_status` rejections do carry a string `column` like `__time_range`, and what actually keeps them out is the intersection with the columns the request named. Description-only change; no code touched, so the approved commit `e99e930` stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
