aminghadersohi commented on PR #43599: URL: https://github.com/apache/superset/pull/43599#issuecomment-5444186482
Thanks for the careful verification @gabotorresruiz — I took the non-blocker rather than deferring it, since you're right that the assertion pinned the exact pattern that hid the bug. `6c153ac` removes `time_grain` from `QUERY_CONTEXT_EXTRA_FORM_DATA_OVERRIDE_KEYS`, so the loop no longer writes a top-level key the query object schema discards. I chose removal over routing it into `extras` to keep parity with the REST path: `form_data_query_context` reads only `extras["time_grain_sqla"]` (superset/common/form_data_query_context.py:319), so `extra_form_data.time_grain` is inert there too — making it live only on the MCP side would be a new divergence, not a fix. `test_merge_form_data_filters_into_query_applies_regular_overrides` now asserts the grain lands in `extras` and that `time_grain` is left at the saved query context's original value rather than overwritten, which pins the absence of the write instead of the write itself. Full `tests/unit_tests/mcp_service/chart/` suite: 1333 passed. `pre-commit run` clean on the changed files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
