AmoghAtreya commented on PR #43176: URL: https://github.com/apache/superset/pull/43176#issuecomment-5446004800
Thanks @gabotorresruiz for the super thorough review and detailed feedback, and @rusackas for checking in! Sorry for the delay on my end—I was out of town for the past week and was unable to work on the fixes. I'm getting to work on the requested fixes now (updating the test stub, fixing the pre-commit issues, and rebasing on master). I'll also address the comments from CodeAnt and update the stale datasource references in get_chart_sql.py so the template context and execution target stay strictly in sync. I'll ping back as soon as the updated commits are pushed and CI is green! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
