rusackas opened a new pull request, #43638:
URL: https://github.com/apache/superset/pull/43638
### SUMMARY
#41031 added five `resultsGrid*` Superset-specific theme tokens
(`resultsGridRowHeight`, `resultsGridHeaderFontWeight`,
`resultsGridHeaderFontSize`, `resultsGridBorderRadius`,
`resultsGridNoStriping`) to customize the AG Grid-backed results grid in SQL
Lab. They were never added to `theming.mdx`, which is where Superset-specific
tokens (chart/dashboard chrome, fonts, etc.) are documented for deployers. This
PR adds a "Results Grid Configuration Overrides" section describing each token
and how to set it via `THEME_DEFAULT` or the theme CRUD JSON editor.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, docs-only change.
### TESTING INSTRUCTIONS
Read the updated section in `docs/admin_docs/configuration/theming.mdx`
("Results Grid Configuration Overrides") and confirm the token names/behavior
match
`superset-frontend/src/SqlLab/components/ResultSet/buildResultsGridThemeOverrides.ts`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
