codeant-ai-for-open-source[bot] commented on code in PR #43636: URL: https://github.com/apache/superset/pull/43636#discussion_r3877828856
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -151,6 +151,16 @@ see some data! You should see months in the rows and Department and Travel Class in the columns. Publish this chart to your existing Tutorial Dashboard you created earlier. +:::note +Row and column totals/subtotals for the Pivot Table are computed by the database, at the same +granularity as the total itself, rather than by summing the already-aggregated cells shown in the +table. This means totals are correct for non-additive metrics too, such as ratios Review Comment: **Suggestion:** The note incorrectly states that all Pivot Table totals and subtotals are computed by the database. Additive metrics such as `SUM` and `COUNT` use a client-side reduction of the leaf query, while only non-additive metrics use database grouping sets. This wording misleads users about where computation occurs and about the effects of row limits and client-side processing. [api mismatch] <details> <summary><b>Severity Level:</b> Minor ๐งน</summary> ```mdx - โ Documentation falsely describes additive total computation. - โ ๏ธ Users may misunderstand cell-limit effects on totals. - โ ๏ธ Additive metrics follow client-side reduction instead. ``` </details> [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5fee3cbcf64f44f7a11b69e06e3e2ed2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5fee3cbcf64f44f7a11b69e06e3e2ed2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/docs/using-superset/exploring-data.mdx **Line:** 155:157 **Comment:** *Api Mismatch: The note incorrectly states that all Pivot Table totals and subtotals are computed by the database. Additive metrics such as `SUM` and `COUNT` use a client-side reduction of the leaf query, while only non-additive metrics use database grouping sets. This wording misleads users about where computation occurs and about the effects of row limits and client-side processing. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43636&comment_hash=6d21fdfc56f2060cf0d5a30feb2f1fc8639a4dd917ae34d1fa8e42730c0f8b7d&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43636&comment_hash=6d21fdfc56f2060cf0d5a30feb2f1fc8639a4dd917ae34d1fa8e42730c0f8b7d&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
