bito-code-review[bot] commented on PR #43637:
URL: https://github.com/apache/superset/pull/43637#issuecomment-5448288847
<!-- Bito Reply -->
The flagged issue is correct. The documentation incorrectly references
`MCP_GUEST_DENIED_TOOLS` as a functional setting, whereas the implementation
relies on an allow-list approach via `MCP_GUEST_ALLOWED_TOOLS`. To resolve
this, the documentation should be updated to reflect the correct configuration
variable and its semantics.
I have implemented the documentation fix below. Please review the changes.
Would you like me to fetch and validate the remaining comments on this PR to
address them as well?
**docs/admin_docs/configuration/mcp-server.mdx**
- Sensitive enumeration tools (`find_users`, `get_instance_info` by default)
are hidden and denied to guests via `MCP_GUEST_ALLOWED_TOOLS`, regardless of
`MCP_RBAC_ENABLED`.
```python
# superset_config.py
MCP_GUEST_ALLOWED_TOOLS = {"all"} - {"find_users", "get_instance_info"} #
default
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
