rusackas commented on code in PR #43319:
URL: https://github.com/apache/superset/pull/43319#discussion_r3877952899
##########
superset/datasets/api.py:
##########
@@ -278,6 +278,18 @@ class DatasetRestApi(SoftDeleteApiMixin,
BaseSupersetModelRestApi):
"database.backend",
"database.allow_multi_catalog",
"columns.advanced_data_type",
+ # Certification/warning metadata is stored serialized in the ``extra``
+ # column and surfaced through model properties. Exposing them keeps
this
+ # payload consistent with the datasource serialization used by Explore,
+ # so clients hydrating from this endpoint don't lose the badges.
+ "columns.certification_details",
+ "columns.certified_by",
+ "columns.is_certified",
+ "columns.warning_markdown",
+ "metrics.certification_details",
+ "metrics.certified_by",
+ "metrics.is_certified",
+ "metrics.warning_markdown",
Review Comment:
Good catch, fixed. Pushed a small cache on
`CertificationMixin.get_extra_dict()` keyed off the raw `extra` string, so the
four certification/warning properties share one `json.loads` per column/metric
instead of reparsing each time, and it self-invalidates if `extra` is mutated
on the instance (0a580f3182).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
